Unsubscribe link - Githubissues

alphagov / notifications-net-client

.NET client for the GOV.UK Notify API

https://www.nuget.org/packages/GovukNotify/

MIT License

25 stars 20 forks source link

Unsubscribe link #187

Closed idavidmcdonald closed 4 months ago

idavidmcdonald commented 4 months ago

What problem does the pull request solve?

Definitely review commit by commit. This is the equivalent of https://github.com/alphagov/notifications-python-client/pull/241 but I've added some other commits that tidy up the tests and do a bunch of minor formatting changes.

Checklist

[x] I’ve used the pull request template
[x] I’ve written unit tests for these changes
[x] I’ve updated the documentation in
- [x] notifications-tech-docs repository
- [x] CHANGELOG.md
[x] I’ve bumped the version number (in src/GovukNotify/GovukNotify.csproj)

CrystalPea commented 4 months ago

Arr ignore my review - I thought this PR is already approved an just needs re-approving after variable name change - but it was not approved in the first place 🤦🏼‍♀️