probleme with the constructor of NotificationClient.cs and the http client used / configured

alphagov / notifications-net-client

.NET client for the GOV.UK Notify API

https://www.nuget.org/packages/GovukNotify/

MIT License

25 stars 20 forks source link

probleme with the constructor of NotificationClient.cs and the http client used / configured #191

Open eccc-fp opened 1 month ago

eccc-fp commented 1 month ago

there is no constructor for NotificationClient.cs that accept an IHttpClient if the baseUrl is not the default one, DI cannot be properly used there

which cause another issue, the HttpClientWrapper.cs doesnt follow proper Guidelines for using HttpClient

which can cause a wide variety of issues and also it is not possible to implement a proper retry pattern

rparke commented 1 month ago

Hi, if you're able to open a PR with an additional constructor to fix this that would be great. Otherwise it may be a few days before we are able to lend some developer time to a fix.