Implement interface - Githubissues

Titansmasher commented 6 years ago

What problem does the pull request solve?

The NotificationClient did not implement the INotificationClient interface. Being unable to use an interface in the place of the NotificationClient makes unit testing rather painful, as we have to instead mock the IHttpClient.

Checklist

[x] I’ve used the pull request template
[ ] I’ve written unit tests for these changes I dont feel this is applicable as no functional code has changed
[ ] I’ve update the documentation (in README.md, CHANGELOG.md and CONTRIBUTING.md) I am unsure if any doccumentation would need to change as the usage of the NotificationClient is unchanged
[x] I’ve bumped the version number (in src/Notify/Notify.csproj)

ghost commented 6 years ago

Can one of the admins verify this patch?

quis commented 6 years ago

Hey @danny-may thanks for the contribution! I’ll get someone who knows more .NET than me to take a look at it.

quis commented 6 years ago

@govuk-notify-jenkins test this please

Titansmasher commented 6 years ago

Im not sure how to merge the commits without re-doing the PR/branch. Is a squash merge not possible from your end?

EDIT: Never mind, I figured it out! @karlbaker02 I think this is all ready

quis commented 6 years ago

@govuk-notify-jenkins test this please

quis commented 6 years ago

Hey @danny-may, @karlbaker02 thanks again for your work on this. Going to merge now…

Titansmasher commented 6 years ago

No problem, happy to help 😄

alphagov / notifications-net-client

Implement interface #57

What problem does the pull request solve?

Checklist