Closed samuelhwilliams closed 1 year ago
Hey @danielcarney96 👋 I'm trying to reproduce your error locally but haven't managed to yet. Please forgive me as I meander through PHP 101 😬
Then building with docker build -t test-php .
and running with docker run -it -e API_KEY -e TEMPLATE_ID test-php php client.php
.
The script runs OK, suggesting the client is installing OK and we're not hitting the lib incompatibility you describe.
Can you share any more about your setup? Do you have other specific lib/client requirements that are causing the incompatibility that we need to be more aware of on our side?
@idavidmcdonald fyi
Hey @danielcarney96 👋 I'm trying to reproduce your error locally but haven't managed to yet. Please forgive me as I meander through PHP 101 😬
Dockerfile (click to open) client.php (click to open) Then building with
docker build -t test-php .
and running withdocker run -it -e API_KEY -e TEMPLATE_ID test-php php client.php
.Resulting
composer.lock
(click to open) The script runs OK, suggesting the client is installing OK and we're not hitting the lib incompatibility you describe.Can you share any more about your setup? Do you have other specific lib/client requirements that are causing the incompatibility that we need to be more aware of on our side?
@idavidmcdonald fyi
Sorry for the slow reply, had a busy couple weeks. Yeah there's incompatibilities with other libraries, basically anything that uses guzzlehttp/guzzle or php-http/guzzle7-adapter as they have the PSR requirement. A couple of examples: laravel framework, symfony framework, aws sdk and many others.
+1 this is something we want for the Make an LPA service, so we are able to upgrade to guzzlehttp/psr7 2.4.
I appreciate all the effort on this, thanks all 👍
Thank you all :)
Kicked off from https://github.com/alphagov/notifications-php-client/pull/119
What problem does the pull request solve?
Update from guzzle5-adapter and guzzle6-adapter to guzzle7-adapter and adjust documentation accordingly.
Release as a major version bump to v5.0.0 to indicate the backwards-incompatible change.
Checklist
DOCUMENTATION.md
andCHANGELOG.md
)const VERSION
insrc/Client.php
)