Allow nhs.net emails as well as .gov.uk ones

alphagov / paas-product-page

0 stars 11 forks source link

Allow nhs.net emails as well as .gov.uk ones #110

Closed richardTowers closed 5 years ago

richardTowers commented 5 years ago

What

Raised in https://govuk.zendesk.com/agent/tickets/3721988

This isn't strictly needed since we can create organisations for NHS people without using the form already. But there's no need to exclude them from the normal process since we've got a non-crown contract now.

How to review

Code review
Check the tests pass
Check out this screenshot

Who can review

Not @richardtowers

46bit commented 5 years ago

If we'd like to whitelist the wider public sector as well, Pay already have a big (but far from exhaustive) list: https://github.com/alphagov/pay-adminusers/blob/master/src/main/java/uk/gov/pay/adminusers/utils/email/EmailValidator.java#L19

richardTowers commented 5 years ago

Yeah, the error message pattern we're using at the moment (where we list all the emails you can have) is not very scalable.

For now I'm happy just to add nhs.