search

alphagov / smart-answers

Serves smart answers on GOV.UK
https://docs.publishing.service.gov.uk/apps/smart-answers.html
MIT License
175 stars 120 forks source link

Visual issue on "business-coronavirus-support-finder" #5434

Closed chris-gds closed 3 years ago

chris-gds commented 3 years ago

Problem

There is a line-height visual issue found on this page. https://www.gov.uk/business-coronavirus-support-finder

Visuals

(Problem: Left, Ideal Solution: Right)

image

Investigation

The rendering element appears here: https://github.com/alphagov/smart-answers/blob/cc59055d1876d8dd4526050515a46cc0c82cf880/app/views/smart_answers/landing.html.erb#L23

This issue appears to come from using the the deprecated govuk_template. Should relevant files be removed this resolves the issue. However the knock on impact would need review.

https://github.com/alphagov/govuk_template/blob/master/source/assets/stylesheets/_basic.scss

Anything else?

Initially it was thought this was related a11y team work, this doesn't appear to be the case. A temporary fix was raised here as a PR however this needs further investigation.

theseanything commented 3 years ago

@chris-gds did this get resolved?

alex-ju commented 3 years ago

Fixed in https://github.com/alphagov/govuk_publishing_components/pull/2273