search

alphagov / specialist-publisher

Publishes specialist documents on GOV.UK
https://docs.publishing.service.gov.uk/apps/specialist-publisher.html
MIT License
10 stars 7 forks source link

[CLOSED] Stop JS from rendering outside of head tag #143

Closed benilovj closed 8 years ago

benilovj commented 8 years ago

Issue by alicebartlett Wednesday 25 June 2014 at 15:37 GMT Originally opened as https://github.com/alphagov/specialist-publisher/pull/143

When I moved to the govuk_admin_template I accidentally left some things outside of content_for tags which meant that there were a whole bunch of script tags at the top of the page before the this caused ie^ and 7 to get very confused, naturally.

Before before

After after

alicebartlett included the following code: https://github.com/alphagov/specialist-publisher/pull/143/commits

benilovj commented 8 years ago

Comment by fofr Thursday 26 June 2014 at 08:12 GMT

FYI The screenshots posted here uncovered a bug with the IE8 shims in the admin gem: https://github.com/alphagov/govuk_admin_template/pull/27

(At that screen width IE8 should be showing a desktop like layout, rather than the mobile first one — respond.js was being loaded before CSS)

benilovj commented 8 years ago

Comment by fofr Thursday 26 June 2014 at 08:40 GMT

Bumping the admin gem to 1.0.1 will now fix this.

benilovj commented 8 years ago

Comment by alicebartlett Monday 30 June 2014 at 09:18 GMT

Hurrah! Thanks @fofr :)