[CLOSED] Add International Development Funds

[benilovj]

Issue by tommyp Thursday 24 July 2014 at 15:30 GMT Originally opened as https://github.com/alphagov/specialist-publisher/pull/184

---

This PR adds International Development Funds to Specialist Publisher for DFID Editors. There's a lot going on in this, but it boils doing to

• bumping govuk_content_models to 16.1.0 to add the new artefact kind
• adding the new schema
• add the new model
• setting up the repo, builder and validator
• adding the views + controllers along with the service registry and view adapter to make these work
• add DFID to the permissions checker

At this point, you can save IDFs, but to publish them the next commit includes the observers with the rest being a reshuffle of a step and then testing creating, editing and publishing of International Development Funds.

Ticket

---

tommyp included the following code: https://github.com/alphagov/specialist-publisher/pull/184/commits

[benilovj]

Comment by rboulton Friday 25 July 2014 at 07:46 GMT

---

There was some discussion in slack about changing "idf_sector" to "development_sector" or similar. It seems like this might be a good time to do that, if it's going to be done.

[benilovj]

Comment by Themitchell Friday 25 July 2014 at 09:53 GMT

---

Added a couple of comments regarding code duplication but otherwise LGTM +1

[benilovj]

Comment by Themitchell Friday 25 July 2014 at 12:42 GMT

---

:+1: Good work!