[CLOSED] Add drug safety updates

benilovj commented 8 years ago

Issue by tommyp Friday 15 August 2014 at 13:49 GMT Originally opened as https://github.com/alphagov/specialist-publisher/pull/230

This PR adds the files necessary for MHRA editors to publish Drug Safety Updates. The commits roughly go as follows:

Add schema
Add Model, Validator and Builder
DRY up the routes so we only need to add a new string for a whole new set of routes
add DSU to the Wiring
add formatters
add permission checks for MHRA
add controllers
add observers and services
add DSU views and routes
testing DSU creating, editing, publishing and withdrawing

tommyp included the following code: https://github.com/alphagov/specialist-publisher/pull/230/commits

benilovj commented 8 years ago

Comment by kalleth Monday 18 August 2014 at 08:11 GMT

This all looks pretty good to me. https://github.com/alphagov/govuk_content_models/pull/217 needs releasing before this can be merged.

benilovj commented 8 years ago

Comment by bestie Monday 18 August 2014 at 10:09 GMT

@kalleth That being the case why do the tests pass?

benilovj commented 8 years ago

Comment by kalleth Monday 18 August 2014 at 10:12 GMT

@bestie I'd guess because the test suite stubs out Panopticon, which is what the above PR for content_models will make work.

benilovj commented 8 years ago

Comment by bestie Monday 18 August 2014 at 10:21 GMT

Ah ok, so you're really waiting on changes to Panopticon, which requires a new content models version.

benilovj commented 8 years ago

Comment by tommyp Monday 18 August 2014 at 10:22 GMT

Aye.

benilovj commented 8 years ago

Comment by Themitchell Monday 18 August 2014 at 15:02 GMT

Added an update of the models gem version to Panopticon https://github.com/alphagov/panopticon/pull/195

benilovj commented 8 years ago

Comment by alicebartlett Tuesday 19 August 2014 at 09:55 GMT

Waiting on a deploy from panopticon before we merge this (slot booked for 1.30 19-aug). Merge this after that has gone out.

alphagov / specialist-publisher