search

alphagov / specialist-publisher

Publishes specialist documents on GOV.UK
https://docs.publishing.service.gov.uk/apps/specialist-publisher.html
MIT License
10 stars 7 forks source link

[CLOSED] Medical safety alerts #231

Closed benilovj closed 8 years ago

benilovj commented 8 years ago

Issue by tommyp Friday 15 August 2014 at 16:21 GMT Originally opened as https://github.com/alphagov/specialist-publisher/pull/231

Just like all the other Finders this PR does the following:

This relies on https://github.com/alphagov/govuk_content_models/pull/218. Ticket.

UPDATE: Panopticon update PR found here: https://github.com/alphagov/panopticon/pull/195

tommyp included the following code: https://github.com/alphagov/specialist-publisher/pull/231/commits

benilovj commented 8 years ago

Comment by tommyp Monday 18 August 2014 at 08:14 GMT

This actually needs a bit of work once https://github.com/alphagov/specialist-publisher/pull/230 gets merged as there will be some conflicts. Namely the views need removed, the form refactored and the config/routes.rb needs to be changed to follow the new DRY approach.

benilovj commented 8 years ago

Comment by bestie Monday 18 August 2014 at 10:08 GMT

This looks good other than mixed use of "medical safety alert" / "drug safety update" is there a logic behind this? This could easily become confusing.

benilovj commented 8 years ago

Comment by tommyp Monday 18 August 2014 at 10:26 GMT

Did I accidentally have Drug Safety Update in this PR or are you referencing the fact that we have 2 similarly named Finders?

benilovj commented 8 years ago

Comment by bestie Monday 18 August 2014 at 10:33 GMT

Yes @AliceNewton just explained the difference to me and I was about to highlight those

benilovj commented 8 years ago

Comment by bestie Monday 18 August 2014 at 12:29 GMT

@tommyp This doesn't seem dependent on #230 am I OK to merge?

benilovj commented 8 years ago

Comment by Themitchell Monday 18 August 2014 at 15:03 GMT

Updated Panopticon to new models gem here:

https://github.com/alphagov/panopticon/pull/195

benilovj commented 8 years ago

Comment by alicebartlett Tuesday 19 August 2014 at 09:56 GMT

Waiting on a deploy from panopticon before we merge this (slot booked for 1.30 19-aug). Merge this after that has gone out.

benilovj commented 8 years ago

Comment by bestie Tuesday 19 August 2014 at 16:10 GMT

Dependencies are satisfied but we're waiting for drug safety updates to be deployed first.

benilovj commented 8 years ago

Comment by Themitchell Wednesday 27 August 2014 at 10:46 GMT

I have added a couple of commits to deal with multi selects. Our new testing strategy should pick this up in future.