alphagov / static

GOV.UK static files and resources
https://docs.publishing.service.gov.uk/apps/static.html
MIT License
20 stars 9 forks source link

Get started button icon position on mobile breakpoint #1248

Closed dashouse closed 6 years ago

dashouse commented 6 years ago

The icon on the get started button is cut off on the mobile breakpoint.

Although there is a specific background-position for this breakpoint, it is is set to 110%. I would suggest changing to something more like 104% for it to be centred inside the right hand padding.

getstarted-button

NickColley commented 6 years ago

This is the old legacy CSS that hasn't been replaced with the new component variation where we fixed this issue.

The markup lives in alphagov/frontend (where we should add the component code) and the CSS is in this repo (which we should remove when it's all gone)

Component to use instead of the legacy button CSS: http://govuk-static.herokuapp.com/component-guide/button/start_now_button_with_info_text/preview

Places where the buttons live: https://github.com/alphagov/frontend/search?utf8=%E2%9C%93&q=button&type=

CSS in this repo to remove: https://github.com/alphagov/static/blob/2e3046b273535ab85bec3eea80d1be66f05f8773/app/assets/stylesheets/helpers/_buttons.scss#L41

An example of the old button rendered: https://www.gov.uk/pay-council-tax/wyre-forest

steventux commented 6 years ago

@dashouse @nickcolley see https://github.com/alphagov/frontend/pull/1402 has been merged. Will be verifying this works on integration this afternoon.

steventux commented 6 years ago

https://www-origin.integration.publishing.service.gov.uk/search-register-planning-decisions/hackney vs. https://www.gov.uk/search-register-planning-decisions/hackney

The button styling is different when using the component, it's simpler and may well solve this issue.

tijmenb commented 6 years ago

This seems to have been fixed by using the magic of components 🎉