search

alphagov / styleguides

GOV.UK coding standards and guidelines for other tools we use
MIT License
196 stars 39 forks source link

Refer to govuk-lint for the Ruby styleguide #102

Closed tijmenb closed 7 years ago

tijmenb commented 7 years ago

This removes the Ruby styleguide. Our conventions are already codified in govuk-lint, so this is duplicated information. The last actual change to the guide was in 2014. All subsequent commits refer to govuk-lint as the source of truth.

alexmuller commented 7 years ago

Also one thing I forgot to add: it would probably be beneficial to rename this from govuk-lint to something like gds_ruby_lint but given how much effort that will take I suspect it's not worth it.

alexmuller commented 7 years ago

https://github.com/alphagov/gds-tech/pull/5

boffbowsh commented 7 years ago

I'd be happy to change that repo and gem to be gds-lint, the intention (and also the practice) it is to provide a linter for other languages too, not just Ruby. It already covers Sass as well. We could do a shuffle quite easily where the next version of govuk-lint simply depends on gds-lint and is empty otherwise?

fofr commented 7 years ago

Is the same also true for Sass linting and https://github.com/alphagov/styleguides/blob/master/css.md?

tijmenb commented 7 years ago

👍 I'll open a new issue on govuk-lint to discuss naming.