Ensure GOV.UK frontend is installed via gemspec - Githubissues

alphagov / tech-docs-gem

Gem to distribute the tech docs project

https://tdt-documentation.london.cloudapps.digital/

MIT License

15 stars 38 forks source link

Ensure GOV.UK frontend is installed via gemspec #103

Closed tlwr closed 5 years ago

tlwr commented 5 years ago

Commit message

The .travis.yml does this but putting it in the gemspec means it happens
locally as well when running 'rake build'

If this gem, when built does not include govuk-frontend, then it
functionally does not work. Add a check in the gemspec that a file from
govuk-frontend exists, so that building the gem will fail if 'npm
install' has not been run, or if govuk-frontend has been removed.

...

What

See commit message

How to review

cd /tmp

mkdir test-govuk-tech-docs

cat <<EOF > Gemfile
source 'https://rubygems.org'

gem 'govuk_tech_docs', '= 2.0.0.pre.test.pre.release.pre.525'
EOF

rbenv shell 2.6.3

gem install bundler:2.0.1

bundle install --path vendor

find vendor/ruby/2.6.0/gems/govuk_tech_docs-2.0.0.pre.test.pre.release.pre.525 -name govuk-frontend -type d

Who can review

Done as pair with Jon Heslop, no review required