search

alphagov / tech-docs-gem

Gem to distribute the tech docs project
https://tdt-documentation.london.cloudapps.digital/
MIT License
15 stars 38 forks source link

Pin openapi3_parser #121

Closed 36degrees closed 4 years ago

36degrees commented 4 years ago

The 0.6.0 release is causing builds to fail. Pinning it to 0.5.2 appears to solve this.

The maintainer of openapi3_parser has been made aware, and hopes to have a new version out soon.

36degrees commented 4 years ago

Mostly raising this to check that it does fix the failing tests currently on master.

If a new release of openapi3_parser is released soon, we may not need to merge this.

kevindew commented 4 years ago

@36degrees I fixed the underlying bug in openapi_parser with 0.6.1 however I discovered (much to my surprise) that this gem also relies on a method that was removed, so I'd suggest you merge this in.

I'm planning to update the code in this gem for compatibility without this method and will open a fresh PR for that (after thoroughly rasping myself for not realising the significance of a BC break) and can update the gem dependency then too.

Apologies for the inconveniences.