search

alphagov / tech-docs-gem

Gem to distribute the tech docs project
https://tdt-documentation.london.cloudapps.digital/
MIT License
15 stars 38 forks source link

Update header alignment to match layout #165

Closed NickColley closed 4 years ago

NickColley commented 4 years ago

This pull request aims to address some spacing issues introduced when this format was updated to use the GOV.UK Design System by aligning the header and layout elements on the page.

It also expands the width of the area for the product name which stops it wrapping early, this is something we might want to consider pushing upstream to GOV.UK Frontend in the future.

Full size before Full size after
Smaller before Smaller after
Even smaller before Even smaller after

Fixes https://github.com/alphagov/tech-docs-gem/issues/164

36degrees commented 4 years ago

It also expands the width of the area for the product name which stops it wrapping early, this is something we might want to consider pushing upstream to GOV.UK Frontend in the future.

Possibly related: https://github.com/alphagov/govuk-frontend/issues/1502

NickColley commented 4 years ago

I've made a small tweak to align this a bit more:

Before After
NickColley commented 4 years ago

@alex-ju if you could help us document where you've done similar things by commenting upstream here: https://github.com/alphagov/govuk-frontend/issues/1502 that'd be really helpful.

NickColley commented 4 years ago

I've asked the graphic designers if I could get an extra pair of eyes on this so will see what they think.

Latest:

NickColley commented 4 years ago

Laurence B and Charlotte D from the GDS graphic designer community have said they approve of this change so I'm going to get it merged.