search

alphagov / tech-docs-gem

Gem to distribute the tech docs project
https://tdt-documentation.london.cloudapps.digital/
MIT License
15 stars 38 forks source link

Remove unnecessary explicit dependencies: sprockets, activesupport, sass and pry #218

Closed kevindew closed 3 years ago

kevindew commented 3 years ago

With the exception of pry, none of these dependencies are explicitly referenced in the code (activesupport and sprockets are implicit though). This removes an unnecessary constraint on sprockets 4, as middleman-sprockets depends on 3 and up which causes problems for apps that integrate with govuk_publishing_components.

⚠️ Don't forget to update the gem version in the CHANGELOG before merging! When you're ready to release bump version file and generate a tag. ⚠️

richardTowers commented 3 years ago

Do you want to bump the version to 2.2.1 in this PR, so we get a new gem when we merge?

kevindew commented 3 years ago

Do you want to bump the version to 2.2.1 in this PR, so we get a new gem when we merge?

I'm optimistically hoping I might get my long protracted bug fix PR into this release too. But if that hits a snag I'll release them separately.