search

alphagov / tech-docs-gem

Gem to distribute the tech docs project
https://tdt-documentation.london.cloudapps.digital/
MIT License
15 stars 38 forks source link

Search result tabbing in mobile view - tab focus gets lost after the final search result #221

Closed iqbalgds closed 3 years ago

iqbalgds commented 3 years ago

Steps to re-create

  1. Make sure you have mobile view.

  2. Click the grey banner Table of contents image

  3. Enter a search term.

  4. Tab through the results.

  5. When you reach the final result and press tab, it should go to the browsers URL window.

  6. However, the tab focus goes to the close TOC button - which is hidden behind then current DIV. So to the user it looks like the tab focus is lost. image

  7. If you press tab again - then it does go to the browser URL.

iqbalgds commented 3 years ago

Raised the following PR to fix this: https://github.com/alphagov/tech-docs-gem/pull/224

iqbalgds commented 3 years ago

This has been released - closing issue.