Closed kr8n3r closed 1 year ago
Thanks for working on this, Jani. Just got a couple of comments, hope they make sense!
I also noticed when running this locally and looking at the Design System frontend docs site that URLs seem to link directly to the first heading on a page, which means the cookie banner is automatically scrolled out of view. I'm not sure where that behaviour comes from, but I wonder what the reason was behind it and if it's something teams could turn off in the config (otherwise it's unlikely anyone will see the banner) ?
it looks like it's driven by in-page-navigation.js
I don't think there's a config setting for this
https://docs.cloud.service.gov.uk/ imports a markdown file for the first page and that somehow circumvents the JS
Build is failing. See https://github.com/alphagov/tech-docs-gem/issues/230 for detail Fixed in #233
Hi @kr8n3r - thanks for working on this! Was it ready for another review or did you need to do more work on it? (I've added @lfdebrux as a reviewer for when it's ready.)
@jonathanglassman Are you ok to work with @kr8n3r on the related documentation PR? I'm happy to pre-i or 2i it.
Hi @kr8n3r - thanks for working on this! Was it ready for another review or did you need to do more work on it? (I've added @lfdebrux as a reviewer for when it's ready.)
@jonathanglassman Are you ok to work with @kr8n3r on the related documentation PR? I'm happy to pre-i or 2i it.
it does require writing tests for it, but that would mean setting up a new test framework. I worked on this when I had some time (which was a while ago) but it's not of any priority for us at the moment
What
Implement a configurable cookie banner based on the GOV.UK Design system cookie banner component
How to test
To do: