Closed 36degrees closed 3 years ago
In 0e9ac92d we updated the header in line with changes made in GOV.UK Frontend v3.13.0, which involved changing the <image> tag to an <img> tag.
<image>
<img>
The path is incorrect (and was before), as the fallback PNG is actually located at /assets/govuk/images/govuk-logotype-crown.png.
/assets/govuk/images/govuk-logotype-crown.png
$ tree build/assets build/assets └── govuk └── assets ├── fonts │ ├── bold-affa96571d-v2.woff │ ├── bold-b542beb274-v2.woff2 │ ├── light-94a07e06a1-v2.woff2 │ └── light-f591b13f7d-v2.woff └── images ├── favicon.ico ├── govuk-apple-touch-icon-152x152.png ├── govuk-apple-touch-icon-167x167.png ├── govuk-apple-touch-icon-180x180.png ├── govuk-apple-touch-icon.png ├── govuk-crest-2x.png ├── govuk-crest.png ├── govuk-logotype-crown.png ├── govuk-mask-icon.svg └── govuk-opengraph-image.png 4 directories, 14 files
Because of the change of tag (presumably) this is now causing downstream builds that have link checkers to fail, like in https://github.com/alphagov/govuk-frontend-docs/pull/139 (build log: https://app.travis-ci.com/github/alphagov/govuk-frontend-docs/builds/233880666).
We could fix the path, but given the layout is already completely broken in IE8 anyway, it seems like it makes more sense just to remove the fallback logic at this point.
In 0e9ac92d we updated the header in line with changes made in GOV.UK Frontend v3.13.0, which involved changing the
<image>tag to an<img>tag.The path is incorrect (and was before), as the fallback PNG is actually located at
/assets/govuk/images/govuk-logotype-crown.png.Because of the change of tag (presumably) this is now causing downstream builds that have link checkers to fail, like in https://github.com/alphagov/govuk-frontend-docs/pull/139 (build log: https://app.travis-ci.com/github/alphagov/govuk-frontend-docs/builds/233880666).
We could fix the path, but given the layout is already completely broken in IE8 anyway, it seems like it makes more sense just to remove the fallback logic at this point.