alphagov / tech-docs-gem

Gem to distribute the tech docs project
https://tdt-documentation.london.cloudapps.digital/
MIT License
15 stars 38 forks source link

Fix CI #280

Closed lfdebrux closed 2 years ago

lfdebrux commented 2 years ago

A v4.4.1 version of middleman was released yesterday that seems to be broken (see for instance failed tests on main branch https://github.com/alphagov/tech-docs-gem/runs/4095543211?check_suite_focus=true).

This PR adds a requirement to the gemspec that rejects this version, so our users won't install it. It also fixes our tests.

lfdebrux commented 2 years ago

This PR is no longer needed, as the release v4.4.1 was yanked from RubyGems by the author and replaced with v4.4.2

https://github.com/middleman/middleman/commit/5647a1b87a060f551d5936f3482ec73e2b73cad2

I'm not sure what was wrong with v4.4.1, but our tests now pass on the main branch, so I'm happy

https://github.com/alphagov/tech-docs-gem/runs/4115161992?check_suite_focus=true