search

alphagov / tech-docs-gem

Gem to distribute the tech docs project
https://tdt-documentation.london.cloudapps.digital/
MIT License
15 stars 38 forks source link

Update to support Ruby v3 #327

Closed TimKnight-DWP closed 1 year ago

TimKnight-DWP commented 1 year ago

What should change

The Gem and dependencies should be updated to support Ruby v3

User need

Ruby v2 has been end-of-life since 31-Mar-23 https://endoflife.date/ruby

lfdebrux commented 1 year ago

Hi @TimKnight-DWP,

Unfortunately this is blocked on support for Ruby 3.x in Middleman, which this gem relies on.

Support for Ruby 3.1 was recently merged to the main branch, however those changes have not yet been released to RubyGems.

TimKnight-DWP commented 1 year ago

@lfdebrux thanks, hopefully soon 🤞

(sadly I am not a Ruby dev so don't feel super confident helping out otherwise I would, don't know the pitfalls )

richardTowers commented 1 year ago

There's now a release of Middleman with support for Ruby 3.1 - v4.5.0

In theory, this gem should now work on Ruby 3.1, but I haven't tested it yet.

jfharden commented 1 year ago

Just to confirm, in GOV.UK Pay we have just updated our tech-docs (which uses this gem) to ruby 3.2.2, we had to also pin HAML to < 6.

The important point being I can confirm for sure the gem from at least ruby 3.3.1 works with ruby 3.2.2.