lfdebrux
commented
1 year ago Looks good, and CI seems happy. Great to have node upgraded too.
we're removing the .ruby-version file, interested in the thinking there? Whilst there's no Gemfile here with the usual referencing of that file, the ruby-version does have some general use, no?
Don't both Rbenv and RVM use that file to try and help setup a devs ruby version?
Might be a gap in my knowledge as I mostly work on applications not gems 🤔
Yeah, totally, it is useful, the only reason I removed it is to avoid duplication of the version numbers... it's hard to remember to update in multiple places, and as the ruby version file doesn't support short version numbers it's a double pain to keep up to date. I'm trying to keep maintenance down basically.
jfharden
What’s changed
Ruby 2.7 has reached end of life, our users want to be able to use the latest stable versions of Ruby. Middleman recently released support for Ruby 3.1 and greater [1], so this gem should be able to work with Ruby 3, but to make sure we should update our test workflows. A few tweaks were needed, including updating the linter, but nothing major.
At the same time we also update the version of Node.js used for the tests, as Node.js 14 reached end of life a while ago as well. I also threw in a fix for the Haml issues (#318), as the tests wouldn't run otherwise.
Identifying a user need
Closes #327.