alphagov / tech-docs-gem

Gem to distribute the tech docs project
https://tdt-documentation.london.cloudapps.digital/
MIT License
15 stars 38 forks source link

Use hidden attribute to show/hide expiry notices #354

Closed tombye closed 1 month ago

tombye commented 1 month ago

This means the notice we want to hide on page load doesn't depend on CSS for that.

It also makes it much clearer in the page semantics that the notices are hidden or not.

What’s changed

The notices for telling users that the page content has expired or not are shown or hidden by the presence of the hidden attribute instead of by CSS.

Identifying a user need

This means the inclusion of the expiry notices is not dependent on CSS to work.

Not strictly accessibility-focused but I have had it raised in the past (by an automated SiteImprove audit) that hiding things by CSS only is a problem and that hidden should be used instead.

Notes for reviewers

I'm not sure what to add to the CHANGELOG because it already has unreleased changes. Happy to do whatever is advised.