search

alphagov / terraform-provider-concourse

A terraform provider for Concourse
MIT License
50 stars 28 forks source link

feat: Adds interface to import pipelines #37

Closed isaacsanders closed 2 years ago

isaacsanders commented 2 years ago

I would like to be able to import pipelines/teams. I don't write a lot of Go code nor do I know a lot about the internals of Concourse, so this might not be useful for a number of reasons.

Let me know if there is anything I can do to help land this in the upstream.

isaacsanders commented 2 years ago

@krenair Are you still a maintainer or do you know any maintainers? I'm asking based on you being the one to merge #33

isaacsanders commented 2 years ago

@nimalank7 Are you a @alphagov maintainer? Can you help with this PR? Asking based on this Golang PR for the org: https://github.com/alphagov/paas-rds-broker/pull/157

isaacsanders commented 2 years ago

@risicle Do you have maintainer on this repo? You are the number 1 committer on https://github.com/terraform-provider-concourse/terraform-provider-concourse/

risicle commented 2 years ago

Hi - sorry, missed this. Will try and get some time to look at it at some point.

risicle commented 2 years ago

Once I've got the integration tests up and working again (see https://github.com/alphagov/terraform-provider-concourse/pull/38), we should add a couple of integration tests to this, and then the only other thing this needs is an addition to the docs covering this.

isaacsanders commented 2 years ago

@risicle I'm not a Go dev, so the changes to go.mod and go.sum are not my intention, if you have something better for me to do with them.

risicle commented 2 years ago

:+1: am currently doing a rebase & tidy of this...

risicle commented 2 years ago

@isaacsanders are you happy for me to push the contents of the isaacsanders-feat-import-pipelines branch to this PR or shall I start another?

https://github.com/alphagov/terraform-provider-concourse/compare/master...isaacsanders-feat-import-pipelines

isaacsanders commented 2 years ago

I would have preferred to have the author preserved, but that's fine.

isaacsanders commented 2 years ago

Ah, I see. It preserved authorship but changed the committer. This works for me.

isaacsanders commented 2 years ago

I've also tested this locally, if you hadn't had a chance.

risicle commented 2 years ago

I'm not sure why your avatar didn't show up next to it like it usually does when there's a separate author/committer

isaacsanders commented 2 years ago

I would bet it is the use of my work email in the user.

On Aug 25, 2022, at 10:31 AM, Robert Scott @.***> wrote:

 I'm not sure why your avatar didn't show up next to it like it usually does when there's a separate author/committer

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

isaacsanders commented 2 years ago

I'm happy for this to merge if you are prepared to merge it.

isaacsanders commented 2 years ago

@AP-Hunt What is the process for releasing the feature?

AP-Hunt commented 2 years ago

@risicle is taking care of it on our side.

Rob, are you able to give a timeframe for the release?