search

alphagov / terraform-provider-concourse

A terraform provider for Concourse
MIT License
50 stars 28 forks source link

use ForceNew for pipeline team change #46

Closed sigwinch28 closed 2 years ago

sigwinch28 commented 2 years ago

We don't need the custom logic for handling a pipeline team change because the Terraform SDK supports destroy-and-create workflows via the ForceNew field on the managed resource schema. Terraform will manage the destroy and create for us.

This means the output of terraform plan shows a more accurate intent, too: it will show the planned destroy and create of the resource.

risicle commented 2 years ago

LGTM, our tests cover this, https://github.com/alphagov/terraform-provider-concourse/actions/runs/3377025650 passes. Will approve after a rebase.

risicle commented 2 years ago

Ok disregard this I'm going to close and reopen this PR to try to trigger the CI run rather than having to do this rebasing dance.