search

alphagov / trade-tariff-backend

Enabling the population and distribution via API of UK Customs tariffs and duties
MIT License
7 stars 6 forks source link

Write API for Trade Tariff Admin app #100

Closed saulius closed 11 years ago

saulius commented 11 years ago

This change is for https://www.pivotaltracker.com/story/show/47984981 and https://www.pivotaltracker.com/story/show/52900709 and is related to https://github.com/alphagov/trade-tariff-admin/pull/1.

See the other pull request for more info.

Environment variables that need to be set for this to work:

TRADE_TARIFF_USER=  '' # user for HTTP basic auth to the backend
TRADE_TARIFF_PASSWORD= '' # password  for HTTP basic auth to the backend
TRADE_TARIFF_OAUTH_ID= '' # has to be generated using signonotron
TRADE_TARIFF_OAUTH_SECRET= '' # has to be generated using signonotron
jabley commented 11 years ago

Should they be environment variables, or just set in a deployment-time initializer?

saulius commented 11 years ago

I checked other app deployment scripts and it looks like we need to upload production version of gds-sso initializer file (https://github.com/alphagov/trade-tariff-backend/pull/100/files#L21R1) instead of relying on environment variables. Publisher seems to be a good reference on how that's accomplished.

matthewford commented 11 years ago

I'll add in the settings for preview after lunch, and then merge.