alphagov / trade-tariff-backend

Enabling the population and distribution via API of UK Customs tariffs and duties
MIT License
7 stars 6 forks source link

CHIEF Excise measure type fix #124

Closed saulius closed 10 years ago

saulius commented 10 years ago

This fix is for https://www.pivotaltracker.com/story/show/59551288

Includes two changes:

  1. We were asked to show values with 4 decimal points on EXCISE measures. So now we show up to 4 decimal points if available and 2 otherwise (just as it works currently).
  2. EXCISE measures "EXCISE - SUSPENSION, 570, REBATED HEAVY OIL, OTHER" and "EXCISE - SUSPENSION, 551, REBATED HEAVY OIL, KEROSENE" should have zero duty rates formatted like this: 0.00 GBP / Litre (Standard Litre of Hydrocarbon Oil). Currently we have 0.00 % (Standard Litre of Hydrocarbon Oil), see https://www.gov.uk/trade-tariff/commodities/3902200010?country=&day=25&month=10&year=2013#import.

This change requires data migrations to be run:

govuk_setenv tariff-api bundle exec rake db:data:migrate

After migration run the measures for screen shot 2013-11-08 at 10 35 00 3902200010 looks like this:

matthewford commented 10 years ago

This needs to be run govuk_setenv tariff-api bundle exec rake db:data:migrate