alphagov / trade-tariff-backend

Enabling the population and distribution via API of UK Customs tariffs and duties
MIT License
7 stars 6 forks source link

Measure change feeds does not return proactively added measures #142

Closed saulius closed 10 years ago

saulius commented 10 years ago

This change is for https://www.pivotaltracker.com/story/show/64645912

How to reproduce? https://www.gov.uk/trade-tariff/commodities/1006209600/changes?as_of=2013-01-31

If I'm querying for commodity changes on 31st of Jan, I should not be seeing Measures that were added on 24th of Jan but have validity start date of 1st of Feb. Showing these causes issues with associations like measure type, because we expect measure type of such measure to be valid at query date (31st of Jan) and if they were introduced at the same time that is not the case (also has validity start date of 1st of Feb).