search

alphagov / trade-tariff-backend

Enabling the population and distribution via API of UK Customs tariffs and duties
MIT License
7 stars 6 forks source link

Enhance `NationalMeasurementUnit` view #200

Closed macool closed 10 years ago

macool commented 10 years ago
matthewford commented 10 years ago

A bit of background. Before we had better formatting of the measurement units, we used to include CHIEF's units into UK measures.

This is not really needed and can cause confusion especially when chief units differ from the EU units they are assigned to, so we are now only displaying them when there is a specific override in the map (for UK specific units):

https://github.com/alphagov/trade-tariff-backend/blob/9f5942429c2d32dd0f48d05f0daa4b69bf2d39ac/app/models/national_measurement_unit.rb#L26-L33

And we also revert a change made during a preview refactor to display these in parentheses.

matthewford commented 10 years ago

@macool can we get some before/after screenshots added to the PR?

macool commented 10 years ago

before: screen shot 2014-08-07 at 11 21 22 am

after: screen shot 2014-08-07 at 11 20 52 am

macool commented 10 years ago

before: screen shot 2014-08-07 at 11 23 17 am

after: screen shot 2014-08-07 at 11 24 04 am

matthewford commented 10 years ago

There is still a little duplication for example EXCISE - 419 which already has the measure unit for liter of alcohol, but for example 415 does not have that measure type, and then in this case more information is useful.