Model specifications - Githubissues

alphagov / trade-tariff-backend

Enabling the population and distribution via API of UK Customs tariffs and duties

MIT License

7 stars 6 forks source link

Model specifications #23

Closed saulius closed 11 years ago

saulius commented 11 years ago

This is cleanup effort:

Remove comments in models (mostly used to be AR association declarations).
Spec out associations, mostly custom ones related to TimeMachine and going back in time.
Extract factories to separate files and and factory validity specs.

saulius commented 11 years ago

Also improves our test coverage by around 10%.

matthewford commented 11 years ago

While we are removing the old commented out AR association code - it should be noted that we will need to eventually implement these relations, for example I am sure HMRC will ask for the meursing calculations to determine specific rates when a meursing code is selected - so to implement some of these will need to reference this commit to see the old associations

saulius commented 11 years ago

It's fine, I see that we will need to reimplement them with conformance tests anyway.