search

alphagov / trade-tariff-backend

Enabling the population and distribution via API of UK Customs tariffs and duties
MIT License
7 stars 6 forks source link

Transformer extensions #33

Closed saulius closed 11 years ago

saulius commented 11 years ago

I split my work on Chief Transform refactor into two parts to make it more manageable. This is general cleanup similar to one in #26 and #27.

Removes unused code, adds logger & additional mail notifications.

Still working on sorting the issue where TARIC updates invalidates national measures, will raise a separate PR.

jabley commented 11 years ago

Are there separate pieces of work to add the email addresses for deployment, and also create any relevant email addresses / verify them to our mail delivery infrastructure?

saulius commented 11 years ago

Hrm, not that I know of. Should I add one? I think Matt mentioned that it was a working email address that we were given for Tariff.

jabley commented 11 years ago

I think I'll need to verify that the email address can be used to send email. It does exist, but I think currently any attempt to send email will fail with a "account not verified" error.

jabley commented 11 years ago

Verified email address and enabled DKIM as well. I'll check the SPF settings, but hopefully we're doing all we can to ensure that emails are delivered.

saulius commented 11 years ago

I myself do not have a way to access the mailbox, but I think if it works it should contain some emails already, as synchronizer sends reports about updates being applied.

jabley commented 11 years ago

There weren't any emails in the mailbox; hopefully we'll see that change over the next day as updates are applied.