search

alphagov / trade-tariff-backend

Enabling the population and distribution via API of UK Customs tariffs and duties
MIT License
7 stars 6 forks source link

TariffSynchronizer supports multiple updates per day #36

Closed saulius closed 11 years ago

saulius commented 11 years ago

We found that Taric issued two updates for 16th and 20th of Nov so therefore we need to extend Synchronizer to support multiple updates per day.

This also fixes issue for commodities under heading 6912 which was reported yesterday.

I'm afraid this update will require snapshot reload, because we missed two Taric updates: TGB12223.xml & TGB12225.xml. Uploaded to Dropbox: snapshot_for_27-11-2012.sql.tar.bz2.

saulius commented 11 years ago

This is applicable just for Taric. CHIEF does not seem to issue multiple update files as all their names seem to be in sync. Unless there is something we don't know yet.

jabley commented 11 years ago

Is it worth asking about CHIEF?

saulius commented 11 years ago

Well CHIEF concerns me a lot because we don't have a clearly defined error handling procedure. It is to this day unknown what happens If certain update file contains an entry which results in validation failure. Will they update the same file? Will they fix their error in tomorrow's update? If so, what should we do about the entry that is failing? If we are going to delete it, then the their fix might not work depending on how they decide to handle it. Or perhaps they'll make a new file for the same day with different file name?

matthewford commented 11 years ago

@jabley it would be good if we could reload say the first snapshot available from production before the 16th onto preview to test this.