search

alphagov / trade-tariff-backend

Enabling the population and distribution via API of UK Customs tariffs and duties
MIT License
7 stars 6 forks source link

Provide geographical_area_id instead of iso_code. #53

Closed saulius closed 11 years ago

saulius commented 11 years ago

Geographical area id is not always an iso code. It's iso code for countries, but otherwise it's geographical area group id. So it should be up to client app to decide when to call this an iso code.

Since the API will be public one day, it is best to expose Taric structure and not invent our own names. There may be other places where such refactorings are needed.

jabley commented 11 years ago

If we expose an ISO code, it should be an ISO code (and a suitably long version). I think that should be a separate field in any API we publish.