search

alphagov / trade-tariff-backend

Enabling the population and distribution via API of UK Customs tariffs and duties
MIT License
7 stars 6 forks source link

Only notify when work has been done #60

Closed jabley closed 11 years ago

jabley commented 11 years ago

Don't bother sending emails saying

"Trade Tariff successfully applied 0 update(s)"

if there were no updates to be actioned.

jabley commented 11 years ago

Hmm, this doesn't appear to do what I thought it would. I'll do the correct thing and write a test, rather than assuming it's too simple to test.

saulius commented 11 years ago

Perhaps the check should have been like this: pending_update_count != 0 && ..

I will refactor some stuff here to put update file names into the letter.

saulius commented 11 years ago

Check https://github.com/alphagov/trade-tariff-backend/pull/62