alphagov / whitehall

Publishes government content on GOV.UK
https://docs.publishing.service.gov.uk/apps/whitehall.html
MIT License
897 stars 194 forks source link

Irish language two-letter code should be ga not gd #9225

Open nacnudus opened 4 months ago

nacnudus commented 4 months ago

https://github.com/alphagov/whitehall/blob/78fb8bdce8fb45ae61409eacb63580a1f2afb922/config/locales/en.yml#L412

Introduced in https://github.com/alphagov/whitehall/pull/4713

Reference: https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes

Noticed by a user of GovSearch. "There seems to be a bug - might be related to Whitehall - for documents that are in Irish. They're classified in GovSearch as 'Scottish Gaelic' rather than 'Gaeilge' or 'Irish'. I think this might be picking up that the Irish language urls wrongly end in '.gd' when they should end in '.ga'."

There are currently three such pages:

vignesh1507 commented 1 month ago

Made the necessary changes to the code.