search

alphaleonis / AlphaFS

AlphaFS is a .NET library providing more complete Win32 file system functionality to the .NET platform than the standard System.IO classes.
http://alphafs.alphaleonis.com/
MIT License
563 stars 99 forks source link

Directory.ExistsDriveOrFolderOrFile fails on global root path, so a simple file copy from a shadow copy fails with "device GLOBALROOT not ready" #433

Closed CyberSinh closed 6 years ago

CyberSinh commented 6 years ago

Seems to be a very severe bug! Hope my simple #432 pull request could help. Thank you for this wonderful library.

Yomodo commented 6 years ago

Thanks!

Yomodo commented 6 years ago

Fixed with #432

CyberSinh commented 6 years ago

Since this is a severe bug, would it be possible to release a new version 2.2.1 of AlphaFS (nuget package) soon?

Yomodo commented 6 years ago

I guess the severity is (only) related to shadow file copying, and not with regular file copies. @alphaleonis Any thoughts on this?

alphaleonis commented 6 years ago

Yeah, the global root paths are not commonly used outside of Shadow copies to my knowledge, but then again, the reason for starting with AlphaFS in the first place was actually to support copying files from shadow copies, so it's a good point. If the bug is fixed I'll do a new release shortly.

@Yomodo Was the fix only done on develop or also on master?

Yomodo commented 6 years ago

@alphaleonis Only in develop.

alphaleonis commented 6 years ago

@Yomodo Okay. Bugfixes should preferrably be made in master, so that new features can be worked on in develop while still releasing minor bugfix releases. But since that's the only fix made so far I'll just merge it down to master and create a new release from there. :)

alphaleonis commented 6 years ago

Fixed in 2.2.1 which has been released now. :)