search

alphaleonis / AlphaFS

AlphaFS is a .NET library providing more complete Win32 file system functionality to the .NET platform than the standard System.IO classes.
http://alphafs.alphaleonis.com/
MIT License
562 stars 99 forks source link

PhysicalDiskInfo class #455 #460

Open Yomodo opened 6 years ago

Yomodo commented 6 years ago

Hi @alphaleonis, I'd appreciate a review on this one, for a v2.3. I think it's ready to go.

Yomodo commented 5 years ago

Hm yeah, perhaps a bit too much for a simple "review", and perhaps not the best word for it.

The majority of the commits are all about the Device.PhysicalDiskInfo class and related members, a new addition to AlphaFS, and not so much about radically changing the existing base code, other than splitting files/methods.

So the review is not about comparing existing base code that has been improved, but more of an approval for this new AlphaFS member.

PhysicalDiskInfo role is to kind of act like a DiskInfo, but aimed at, well, physical disks. The issues you pointed out is exactly what I mean.

alphaleonis commented 5 years ago

Alright, I'll have another look at the PhysicalDiskInfo class shortly then and get back to you. :)