alphanodes / additional_tags

Redmine Plugin for adding tags functionality to issues and wiki pages.
https://www.redmine.org/plugins/additional_tags
GNU General Public License v2.0
64 stars 27 forks source link

Add tags for multiple selection #26

Closed cristian-spiescu closed 1 year ago

cristian-spiescu commented 2 years ago

Hi!

Just like the original "Redmine UP Tags plugin", there is an issue when trying to add a tag for a multiple selection. E.g. I have task1 and task2 as follows: image

I select the 2 tasks, and I click on "add tag": image

image

I want to add "tag2" to both tags: image

The above dialog behaves actually like "set tags". Not like "add tags".

Actually this is the reason why we cannot use this plugin. People may want to bulk add some tags, and they may end in corrupting the tasks.

Thanks in advance! Cristian

cristian-spiescu commented 2 years ago

I find it interesting that this issue wasn't discovered until now, and that it seems not to bother people. Anyway, for us, it's a showstopper. We'll try to fix it and propose a PR. I hope the repo policy is to review and try to merge PRs from users external to the project. It's a bit challenging because we are not Ruby devs, but let's see what we manage to do.

Theodorson commented 2 years ago

Hi,

I am colleague with @cristian-spiescu and I made a fix for this issue. This is the PR for fixing issue https://github.com/AlphaNodes/additional_tags/pull/27. Please look in PR for release notes which contains explanations of what I did and screenshots.

Theodorson commented 2 years ago

Hi,

I fixed the tests. Now I think the PR can be merged. Can you please approve to run the build again ?

Theodorson commented 2 years ago

Hi, I fixed linter too. I didn't modified with nothing the places with problems, I don't know how it passed in the past, anyway, now I think is fine. Can you please approve to run the build again ?

Theodorson commented 2 years ago

Hi, Was one more problem with a slim file. Can you please approve to run the build again ?

Theodorson commented 2 years ago

Hi, Could you please approve to trigger another build ?

alexandermeindl commented 1 year ago

This is fixed with #39