search

alphanodes / additional_tags

Redmine Plugin for adding tags functionality to issues and wiki pages.
https://www.redmine.org/plugins/additional_tags
GNU General Public License v2.0
64 stars 26 forks source link

Fixed 'Add tags'. Added 'Edit tags' #39

Closed Theodorson closed 1 year ago

alexandermeindl commented 1 year ago

I'll not except this PR, because other code is overwritten, which changed in the last weeks. Please fix this. Also why do you think you can change the release version?

Theodorson commented 1 year ago

I've fixed it. Sorry. I don't understand the part about release version.

Theodorson commented 1 year ago

Hi @alexandermeindl,

I've fixed linter and tests. Could you please trigger another build ?

Theodorson commented 1 year ago

Hi @alexandermeindl ,

Could you please trigger another build ? A problem still exists ?

alexandermeindl commented 1 year ago

Hi @Theodorson,

thanks for you contribution, it is now merged to main branch!

alexandermeindl commented 1 year ago

Hii @Theodorson, I found a bug with your pr: no journal entries are created in issues, if you add tags. Can you provide a fix for it in a new pr?

Theodorson commented 1 year ago

Hi @alexandermeindl I understand add tags is not doing the same with the save tags from issue page right ? I've tested with a older branch without my changes and also doesn't works. I'm not sure is a bug from my PR. I would like to repair/add this behavior what should exists. image image

alexandermeindl commented 1 year ago

Hi @Theodorson, this would be great!

Journal for tags is tricky, I spent some hours, days for it on other actions (edit form, tag edit on show, creating new issues, deleting tags,...). It was not easy to find a solution, which worked for all this actions. Maybe you are right, that adding tags on context-menu never worked with journal entries.

It would be really great if you have time for it and can find a solution.

Theodorson commented 1 year ago

Hi @alexandermeindl,

Happy new year!

I was in holiday. I will try to add this feature when I will have some free time, I spoke with a colleague and I think we found a solution. I will come back with news about it.