addtional_tags can't coexist with other plugin redmine_more_previews

[Raw1mage]

Great plugin !

One issue need help. When I install another plugin, https://github.com/HugoHasenbein/redmine_more_previews

This additional_tags plugin is screwed.

The browser shows: An error occurred while executing dashboard block issue_tags and has been logged. Please report this error to your Redmine administrator.

The Logs show:

lib/redmine/sudo_mode.rb:61:in `sudo_mode' I, [2023-08-05T20:04:57.062647 #1] INFO -- : Started GET "/settings/plugin/additional_tags" for 1.34.74.47 at 2023-08-05 20:04:57 +0000 I, [2023-08-05T20:04:57.063525 #1] INFO -- : Processing by SettingsController#plugin as HTML I, [2023-08-05T20:04:57.063570 #1] INFO -- : Parameters: {"id"=>"additional_tags"} I, [2023-08-05T20:04:57.068755 #1] INFO -- : Current user: sysadmin (id=1) I, [2023-08-05T20:04:57.080076 #1] INFO -- : Rendered settings/plugin.html.erb within layouts/admin (Duration: 10.0ms | Allocations: 5732) I, [2023-08-05T20:04:57.080169 #1] INFO -- : Rendered layout layouts/admin.html.erb (Duration: 10.1ms | Allocations: 5760) I, [2023-08-05T20:04:57.080409 #1] INFO -- : Completed 500 Internal Server Error in 17ms (ActiveRecord: 2.6ms | Allocations: 7156) F, [2023-08-05T20:04:57.082346 #1] FATAL -- : ActionView::Template::Error (Array::ArrayRowIsNotAHash): 9: title: "#{l :button_check_all}/#{l :button_uncheck_all}" 10: 11: th = l :field_name 12: - manageable_tag_columns.each do |_column, column_values| 13: th = column_values[:label] 14: th 15: tbody

[Raw1mage]

Providing more logs:

• Internal error An error occurred on the page you were trying to access. If you continue to experience problems please contact your Redmine administrator for assistance.

If you are the Redmine administrator, check your log files for details about the error.

[Back](javascript:history.back())

• docker logs I, [2023-08-21T15:56:40.022174 #1] INFO -- : Started GET "/projects/ilrdfmis" for 1.34.74.47 at 2023-08-21 15:56:40 +0000 I, [2023-08-21T15:56:40.023411 #1] INFO -- : Processing by ProjectsController#show as HTML I, [2023-08-21T15:56:40.023475 #1] INFO -- : Parameters: {"id"=>"ilrdfmis"} I, [2023-08-21T15:56:40.029139 #1] INFO -- : Current user: sysadmin (id=1) I, [2023-08-21T15:56:40.590109 #1] INFO -- : Rendered plugins/additionals/app/views/projects/show.html.slim within layouts/base (Duration: 443.9ms | Allocations: 123418) I, [2023-08-21T15:56:40.711571 #1] INFO -- : Rendered layout layouts/base.html.erb (Duration: 565.4ms | Allocations: 161102) I, [2023-08-21T15:56:40.712181 #1] INFO -- : Completed 200 OK in 689ms (Views: 537.5ms | ActiveRecord: 49.7ms | Allocations: 203068) I, [2023-08-21T15:56:40.788298 #1] INFO -- : Started GET "/projects/ilrdfmis/dashboard_async_blocks?block=issuequery&dashboard_id=6&unique_key=c07b5683aa0ebd4a6b71106662591b900a0946f235e7b" for 1.34.74.47 at 2023-08-21 15:56:40 +0000 I, [2023-08-21T15:56:40.789769 #1] INFO -- : Processing by DashboardAsyncBlocksController#show as / I, [2023-08-21T15:56:40.789837 #1] INFO -- : Parameters: {"block"=>"issuequery", "dashboard_id"=>"6", "unique_key"=>"c07b5683aa0ebd4a6b71106662591b900a0946f235e7b", "project_id"=>"ilrdfmis"} I, [2023-08-21T15:56:40.795862 #1] INFO -- : Current user: sysadmin (id=1) E, [2023-08-21T15:56:40.913184 #1] ERROR -- : Deface: 'disable_project_link_if_current_user_cannot_open_it' matched 0 times with 'table.list.issues tbody tr' I, [2023-08-21T15:56:40.966433 #1] INFO -- : Completed 200 OK in 176ms (Views: 143.5ms | ActiveRecord: 19.1ms | Allocations: 69512) I, [2023-08-21T15:56:41.036828 #1] INFO -- : Started HEAD "/" for 127.0.0.1 at 2023-08-21 15:56:41 +0000 I, [2023-08-21T15:56:41.038124 #1] INFO -- : Processing by WelcomeController#index as / I, [2023-08-21T15:56:41.066682 #1] INFO -- : Current user: anonymous I, [2023-08-21T15:56:41.257645 #1] INFO -- : Rendered plugins/additionals/app/views/welcome/index.html.slim within layouts/base (Duration: 110.0ms | Allocations: 55207) I, [2023-08-21T15:56:41.345771 #1] INFO -- : Rendered layout layouts/base.html.erb (Duration: 198.2ms | Allocations: 95626) I, [2023-08-21T15:56:41.346166 #1] INFO -- : Completed 200 OK in 308ms (Views: 195.3ms | ActiveRecord: 14.7ms | Allocations: 138605) I, [2023-08-21T15:56:45.185609 #1] INFO -- : Started GET "/issues/55" for 1.34.74.47 at 2023-08-21 15:56:45 +0000 I, [2023-08-21T15:56:45.186933 #1] INFO -- : Processing by IssuesController#show as HTML I, [2023-08-21T15:56:45.186995 #1] INFO -- : Parameters: {"id"=>"55"} I, [2023-08-21T15:56:45.193422 #1] INFO -- : Current user: sysadmin (id=1) E, [2023-08-21T15:56:45.329550 #1] ERROR -- : Deface: [ERROR] The original source for 'show-projects-in-issue-description' has changed, this override should be reviewed to ensure it's still valid. E, [2023-08-21T15:56:46.172271 #1] ERROR -- : Deface: [ERROR] The original source for 'add-multiple-projects-to-issue-form' has changed, this override should be reviewed to ensure it's still valid. I, [2023-08-21T15:56:46.449211 #1] INFO -- : Rendered issues/show.html.erb within layouts/base (Duration: 1124.7ms | Allocations: 304580) I, [2023-08-21T15:56:46.449302 #1] INFO -- : Rendered layout layouts/base.html.erb (Duration: 1124.9ms | Allocations: 304622) I, [2023-08-21T15:56:46.449669 #1] INFO -- : Completed 500 Internal Server Error in 1263ms (ActiveRecord: 79.8ms | Allocations: 343706) F, [2023-08-21T15:56:46.451349 #1] FATAL -- : ActionView::Template::Error (Array::ArrayRowIsNotAHash): 1: - if AdditionalTags.setting?(:active_issue_tags) && \ 2: User.current.allowed_to?(:view_issue_tags, @project, global: true) && \ 3: defined?(sidebar_tags) && \ 4: sidebar_tags.present? 5: 6: .sidebar-tags 7: h3 = l :field_tags

plugins/additional_tags/lib/additional_tags/tags.rb:149:in table_columns' plugins/additional_tags/lib/additional_tags/tags.rb:35:inavailable_tags' plugins/additional_tags/lib/additional_tags/patches/issue_patch.rb:49:in available_tags' plugins/additional_tags/app/helpers/additional_tags_issues_helper.rb:49:insidebar_tags' plugins/additional_tags/app/views/issues/_tags_sidebar.html.slim:4 lib/redmine/hook/view_listener.rb:61:in block (2 levels) in render_on' lib/redmine/hook/view_listener.rb:59:inmap' lib/redmine/hook/view_listener.rb:59:in block in render_on' lib/redmine/hook.rb:66:inblock (2 levels) in call_hook' lib/redmine/hook.rb:66:in each' lib/redmine/hook.rb:66:inblock in call_hook' lib/redmine/hook.rb:63:in call_hook' lib/redmine/hook.rb:101:incall_hook' app/views/issues/_sidebar.html.erb:2 app/views/issues/show.html.erb:148 app/views/issues/show.html.erb:147 app/controllers/issues_controller.rb:118:in block (2 levels) in show' app/controllers/issues_controller.rb:110:inshow' lib/redmine/sudo_mode.rb:61:in sudo_mode' plugins/redmine_dmsf/lib/redmine_dmsf/webdav/custom_middleware.rb:55:incall'

[batrachian]

Was just trying to add redmine_more_previews to our redmine installation and encountered the very same issue:

F, [2023-10-08T03:05:25.360235 #9893] FATAL -- : [47a97f8d-94d4-4b6c-939e-7943f247591e]   
[47a97f8d-94d4-4b6c-939e-7943f247591e] ActionView::Template::Error (Array::ArrayRowIsNotAHash):
[47a97f8d-94d4-4b6c-939e-7943f247591e]     1: - if AdditionalTags.setting?(:active_issue_tags) && \
[47a97f8d-94d4-4b6c-939e-7943f247591e]     2:      User.current.allowed_to?(:view_issue_tags, @project, global: true) && \
[47a97f8d-94d4-4b6c-939e-7943f247591e]     3:      defined?(sidebar_tags) && \
[47a97f8d-94d4-4b6c-939e-7943f247591e]     4:      sidebar_tags.present?
[47a97f8d-94d4-4b6c-939e-7943f247591e]     5: 
[47a97f8d-94d4-4b6c-939e-7943f247591e]     6:   .sidebar-tags
[47a97f8d-94d4-4b6c-939e-7943f247591e]     7:     h3 = l :field_tags
[47a97f8d-94d4-4b6c-939e-7943f247591e]   
[47a97f8d-94d4-4b6c-939e-7943f247591e] plugins/additional_tags/lib/additional_tags/tags.rb:149:in `table_columns'
[47a97f8d-94d4-4b6c-939e-7943f247591e] plugins/additional_tags/lib/additional_tags/tags.rb:35:in `available_tags'
[47a97f8d-94d4-4b6c-939e-7943f247591e] plugins/additional_tags/lib/additional_tags/patches/issue_patch.rb:49:in `available_tags'
[47a97f8d-94d4-4b6c-939e-7943f247591e] plugins/additional_tags/app/helpers/additional_tags_issues_helper.rb:49:in `sidebar_tags'
[47a97f8d-94d4-4b6c-939e-7943f247591e] plugins/additional_tags/app/views/issues/_tags_sidebar.html.slim:4
[47a97f8d-94d4-4b6c-939e-7943f247591e] lib/redmine/hook/view_listener.rb:61:in `block (2 levels) in render_on'
[47a97f8d-94d4-4b6c-939e-7943f247591e] lib/redmine/hook/view_listener.rb:59:in `map'
[47a97f8d-94d4-4b6c-939e-7943f247591e] lib/redmine/hook/view_listener.rb:59:in `block in render_on'
[47a97f8d-94d4-4b6c-939e-7943f247591e] lib/redmine/hook.rb:66:in `block (2 levels) in call_hook'
[47a97f8d-94d4-4b6c-939e-7943f247591e] lib/redmine/hook.rb:66:in `each'
[47a97f8d-94d4-4b6c-939e-7943f247591e] lib/redmine/hook.rb:66:in `block in call_hook'
[47a97f8d-94d4-4b6c-939e-7943f247591e] lib/redmine/hook.rb:63:in `call_hook'
[47a97f8d-94d4-4b6c-939e-7943f247591e] lib/redmine/hook.rb:101:in `call_hook'
[47a97f8d-94d4-4b6c-939e-7943f247591e] app/views/issues/_sidebar.html.erb:2
[47a97f8d-94d4-4b6c-939e-7943f247591e] app/views/issues/show.html.erb:137
[47a97f8d-94d4-4b6c-939e-7943f247591e] app/views/issues/show.html.erb:136
[47a97f8d-94d4-4b6c-939e-7943f247591e] app/controllers/issues_controller.rb:118:in `block (2 levels) in show'
[47a97f8d-94d4-4b6c-939e-7943f247591e] app/controllers/issues_controller.rb:110:in `show'
[47a97f8d-94d4-4b6c-939e-7943f247591e] lib/redmine/sudo_mode.rb:61:in `sudo_mode'

[batrachian]

Stephan responded to the Issue on redmine_more_previews#91

As noted there, the to_list array method defined in additionals/lib/additionals.rb conflicts with one in their own utility which is used extensively and due to the minimal number of instances of the use of this method in additionals/additional_tags it is suggested that it could be named something else here.

[alexandermeindl]

Hi @batrachian, this method in additionals is used in all our plugins (in about 400 different places). We cannot rename it without lots of work - therefore this change is not planed at the moment.

For your information: additionals is used as base plugin for all other plugins, we developed.

[batrachian]

Hi, that's understandable. Hopefully both projects can do a rename in a future major version change or find a namespace-safe method.

For anyone looking to patch the additionals/additional_tags plugins as a work-around, the diffs are attached - changes to_list to to_cslist (for "comma-separated" list). Or alternatively the changes are quite easy to do manually.

additional_tags-rename-to_list.patch additionals-rename-to_list.patch

[alexandermeindl]

Fix in main branch