search

alphanodes / additionals

Redmine plugin for easy customization of settings, text and content display by using personal or role-based dashboards (drag&drop), providing wiki macros and act as library for other plugins.
https://www.redmine.org/plugins/additionals
GNU General Public License v2.0
131 stars 43 forks source link

Recursion Crash when going to settings page, news page and documents page #76

Open tqing1128 opened 4 years ago

tqing1128 commented 4 years ago

I use docker redmine:4

when I go to administration -> settings, projects-> settings, news page and documents page. I get a recursive issue:

plugins/redmine_quick_replies/lib/redmine_quick_replies/patches/wiki_formatting_patch.rb:17:in heads_for_wiki_formatter_with_redmine_quick_replies' plugins/additionals/lib/additionals/patches/formatting_helper_patch.rb:10:inheads_for_wiki_formatter' plugins/additionals/lib/additionals/patches/formatting_helper_patch.rb:10:in heads_for_wiki_formatter' plugins/redmine_quick_replies/lib/redmine_quick_replies/patches/wiki_formatting_patch.rb:17:inheads_for_wiki_formatter_with_redmine_quick_replies' plugins/additionals/lib/additionals/patches/formatting_helper_patch.rb:10:in `heads_for_wiki_formatter' ... ... ...

I think it conflicts with redmine_quick_replies plus

alexandermeindl commented 4 years ago

Hi @TQING1990,

same as here https://github.com/AlphaNodes/additionals/issues/71#issuecomment-591290491

This cannot be fixed, because a plugin can only be use prepend or alias_method. More plugins use prepend - and is more modern - of these reasons additionals plugins use prepend (redmine_quick_replies uses alias_method).

More interesting information to this topic can be found here: https://www.justinweiss.com/articles/rails-5-module-number-prepend-and-the-end-of-alias-method-chain/

tqing1128 commented 4 years ago

thanks