Fix conflict with other plugins patching the same method

[pgrenaud]

Hi!

When installing this plugin, I noticed a conflict with an other plugin causing 500 errors on any page with a text area. According to redmine logs, an infinite recursive call occur between two patches trying to patch the heads_for_wiki_formatter method.

The conflicting patches in question:

• AlphaNodes/additionals:/lib/additionals/patches/formatting_helper_patch.rb
• eXolnet/redmine_quick_replies:/lib/redmine_quick_replies/patches/wiki_formatting_patch.rb

This PR fix the way the heads_for_wiki_formatter method is patch, using the same way the sidebar method is patch (see wiki_patch.rb).

I have tested this PR on our staging area and it does fix the issue. Let me know if you have any comments on the PR.

Thanks!

[alexandermeindl]

Hi @pgrenaud

thanks for your work, but I have to deny this PR.

More and more plugins uses prepend instead of alias_method. You have to choose one of them. Because of prepend is the more modern solution, we decided to use is wherever is possible. We use other plugins together with additionals, which uses prepend for this patch. That's the reason.

In a perfect world, all plugins would use prepend nowadays :relieved:

[pgrenaud]

I did not think about doing it the other way around 🤦 (it does work)

Thanks!