alphanodes / redmine_messenger

Messenger plugin for Redmine with Slack, Discord, Rocket.Chat and Mattermost support
https://www.redmine.org/plugins/redmine_messenger
Other
175 stars 59 forks source link

Incorrect quote display #10

Closed ghost closed 4 years ago

ghost commented 7 years ago

I'm using RocketChat and a quote inside a ticket description is displayed as &#39 instead of quote.

alexandermeindl commented 7 years ago

I cannot reproduce this problem. Can you give my some information about your environment? Which Redmine version, which Ruby version do you use? And please use the latest redmine_messenger plugin version. Do you have Redmine plugins installed, which may conflict with it (e.g. CKEditor)?

ghost commented 7 years ago

Thx for your answer :-)

Server:

Client:

For custom rebuild I followed:

I presume the escape come from ERB::Util.html_escape function because

&
<
>
'

are changed into

&amp;
&lt;
&gt;
&#39;
ZerooCool commented 5 years ago

' become ' with slack

The same with Debian 9 stable + RVM and Redmine 4.0.2 https://wiki.visionduweb.fr/index.php?title=Installer_Redmine_sur_Debian_avec_RVM

How i install the plugin https://wiki.visionduweb.fr/index.php?title=Installer_Redmine_sur_Debian#redmine_messenger

Environment: Redmine version 4.0.3.stable Ruby version 2.4.5-p335 (2018-10-18) [x86_64-linux] Rails version 5.2.3 Environment production Database adapter Mysql2 Mailer queue ActiveJob::QueueAdapters::AsyncAdapter Mailer delivery smtp SCM: Filesystem
Redmine plugins: redmine_messenger 1.0.3

alexandermeindl commented 4 years ago

See #38 for fix.