search

alphapapa / activities.el

Activities for Emacs (suspend and resume activities, i.e. frames/tabs and their windows, buffers)
GNU General Public License v3.0
207 stars 12 forks source link

Discarding an activity does not discard its mirrored bookmark #96

Open shipmints opened 4 months ago

shipmints commented 4 months ago

Seems easy enough to reproduce. Create an activity, wait for the time interval for bookmarks to be saved and also activities to persist. Discard an activity. The bookmark remains behind.

Shite, sorry. While I am writing this, I took a look at the source code for activities-discard, it says:

  ;; TODO: Discard relevant bookmarks when `activities-bookmark-store' is enabled.

I guess this issue can stand as a reminder to contributors to write that code. It could be me if I can learn the necessary elisp skills.

alphapapa commented 4 months ago

Yeah, just haven't bothered to do it yet. Wasn't sure if the automatically created bookmarks would be universally appreciated, anyway. Patches welcome, or I'll get to it eventually. If you do want to try your hand at it, I'll be glad to assist with Elispisms.

shipmints commented 4 months ago

I hear you. If activities bookmarks aren't long for this world, it wouldn't kill me. I prefer using the activities API itself vs. bookmarks despite them being a natural part of the current implementation.

alphapapa commented 4 months ago

I don't think I'll be removing the feature, but I might be convinced to disable it by default.

shipmints commented 4 months ago

Giving this a shot.

shipmints commented 4 months ago

See #101.

shipmints commented 2 months ago

Finally getting back to this. Pushed updates accommodating your comments.