search

alphapapa / burly.el

Save and restore frames and windows with their buffers in Emacs
GNU General Public License v3.0
303 stars 14 forks source link

Fixed problem with plists in pcase-let #1

Closed alastairdb closed 3 years ago

alastairdb commented 3 years ago

burly-revive seems to expect a newish version of map.el to handle plist short-hand syntax. Perhaps, the old long-hand syntax could be used until this is generally available

alphapapa commented 3 years ago

Yes, that is why map 2.1 is required, see https://github.com/alphapapa/burly.el/blob/e78347bfafad1bc49ab27d13f2a7648cad60a097/burly.el#L8 You can install it from ELPA.

See also https://github.com/emacs-mirror/emacs/commit/e287da5a8154d83a97107b64915ccc17e3a086b8

alastairdb commented 3 years ago

Yes, that is why map 2.1 is required, see

https://github.com/alphapapa/burly.el/blob/e78347bfafad1bc49ab27d13f2a7648cad60a097/burly.el#L8

You can install it from ELPA.

I encountered this problem when I used the quelpa recipe in the README file

alphapapa commented 3 years ago

AFAIK Quelpa should install the newer version of map.el from ELPA. When I tested it in a clean Emacs profile, it did. If it doesn't, you might have a configuration problem, or you might want to seek help from Quelpa. It's not a bug in this package.

alastairdb commented 3 years ago

map.el for version 2.1 was under my ~/.emacs.d/elpa directory but was not being picked up in the macro expansion. In the end, I loaded the .el and .el.gz versions of pcase, map and burly-revive by hand. Then I byte compiled map and burly-revive again. Then it worked!