search

alphapapa / burly.el

Save and restore frames and windows with their buffers in Emacs
GNU General Public License v3.0
301 stars 14 forks source link

burly-open-bookmark completion shows no entries after startup #21

Closed minad closed 11 months ago

minad commented 3 years ago

Hi,

I like the idea of reusing builtin functionality for the purpose of storing window/frame configuration! I've one small issue though - After starting Emacs, M-x burly-open-bookmark shows no entries, since the bookmark file is somehow not yet loaded. After M-x bookmark-jump the file is loaded and then burly is populated too, when doing M-x burly-open-bookmark again.

Independently of the issue, I wonder if it is necessary to do the URL encoding? It seems to me that bookmarks can be simple alists? Generally I would prefer to use the native elisp format instead of the less readable url encoding. Or maybe there is a technical reason to use the url format? Is it the idea that urls are better for external sharing? Does burly also hook into some internal emacs url mechanism for opening urls? Your readme states that you also provide commands working with the URL strings, with the added qualification that most users probably won't use these.

alphapapa commented 3 years ago

Thanks, that will be a simple bug to fix. I assumed that bookmark-alist was loaded automatically, but apparently not.

URLs are an implementation detail at the moment. For more discussion, please see https://github.com/alphapapa/burly.el/issues/7

minad commented 3 years ago

@alphapapa Thank you for the answer, I will read through #7 and maybe comment there!

ssl19 commented 2 years ago

According to bookmark-view.el, I've found out a workaround : (advice-add 'burly-bookmark-names :before (lambda () (bookmark-maybe-load-default-file)))

I'm not very familiar with Emacs and Elisp, so I don't know if this has any side effects