Open tumashu opened 3 years ago
Thanks, but when sending a PR, you should explain the rationale. And when adding a new feature or workaround, as this one seems to, it should generally be discussed in an issue first, because this may not be the best approach to take.
The reason is simple: (burly-url-buffer burly-url) sometime return nil, In this condition, burly will switch to stratch buffer, instead of pop error.
That would seem like "papering over" the problem of some buffers not being restorable. It would seem preferable to give an error that the user can report so the problem can be fixed properly. Otherwise, users will simply see that Burly does not appear to work properly, restoring a scratch buffer instead of the desired one.
It would seem preferable to give an error that the user can report so the problem can be fixed properly.
I do not think so, give a message better than error, burly can not handle all the cases, fallback to scratch and let user manual handle is very useful.
AFAIK this is solved now, but I'll revisit for 0.4.