Add burly-default-buffer, fix #30

alphapapa / burly.el

Save and restore frames and windows with their buffers in Emacs

GNU General Public License v3.0

301 stars 14 forks source link

Add burly-default-buffer, fix #30 #31

Open tumashu opened 3 years ago

tumashu commented 3 years ago

burly.el (burly-default-buffer): New variable. (burly--bufferize-window-state): use `burly-default-buffer'.

alphapapa commented 3 years ago

Thanks, but when sending a PR, you should explain the rationale. And when adding a new feature or workaround, as this one seems to, it should generally be discussed in an issue first, because this may not be the best approach to take.

tumashu commented 3 years ago

The reason is simple: (burly-url-buffer burly-url) sometime return nil, In this condition, burly will switch to stratch buffer, instead of pop error.

alphapapa commented 3 years ago

That would seem like "papering over" the problem of some buffers not being restorable. It would seem preferable to give an error that the user can report so the problem can be fixed properly. Otherwise, users will simply see that Burly does not appear to work properly, restoring a scratch buffer instead of the desired one.

tumashu commented 3 years ago

It would seem preferable to give an error that the user can report so the problem can be fixed properly.

I do not think so, give a message better than error, burly can not handle all the cases, fallback to scratch and let user manual handle is very useful.

alphapapa commented 11 months ago

AFAIK this is solved now, but I'll revisit for 0.4.