search

alphapapa / burly.el

Save and restore frames and windows with their buffers in Emacs
GNU General Public License v3.0
303 stars 14 forks source link

Save/restore multiple frames #8

Closed poulpoulsen closed 3 years ago

poulpoulsen commented 3 years ago

Hello, i just discovered, that burly could not restore more then one frame. Is this a development status or a bug? I create three frames with C-x 5 2. Then i saved the bookmark. bookmark-jump restored only one frame with all windows.

Regards Poul

alphapapa commented 3 years ago

Hi Poul,

As the documentation says, the burly-bookmark-windows command bookmarks "the current frame’s window configuration." It may be possible to write another command to restore multiple frames. I may look into that sometime. In the meantime, you'll have to bookmark each frame separately.

poulpoulsen commented 3 years ago

Thank you. I will handle this for multiple frames and hope that in the future, there will be an enhancement for saving all frames at once. .

rswgnu commented 3 years ago

See: https://github.com/alphapapa/burly.el/issues/7#issuecomment-716920511

alphapapa commented 3 years ago

@poulpoulsen @rswgnu Implemented with https://github.com/alphapapa/burly.el/commit/e238c9becaea198d7786d3208c04594b8e2a9514. Lightly tested, but it seems to work. Please let me know how it works for you.

alphapapa commented 3 years ago

BTW, what do you think about removing the burly-bookmark-windows command and moving its functionality into burly-bookmark-frame? It would bookmark the current frame, and with a prefix argument it would bookmark all frames. I feel like that might be clearer to users.

rswgnu commented 3 years ago

I would have two commands: burly-bookmark-frameset for multiple frames and burly-bookmark-wconfig (to use the Emacs term) or burly-bookmark-frame if you prefer. It would be okay for a prefix arg to the wconfig cmd to invoke the frameset command but I think you want the functions do be separate when programming to distinguish the types if objects they store

alphapapa commented 3 years ago

That's a good idea. Thanks.