search

alphapapa / ement.el

A Matrix client for GNU Emacs
GNU General Public License v3.0
476 stars 44 forks source link

Configurable emoji reaction picker #201

Closed oantolin closed 3 months ago

oantolin commented 10 months ago

I think this is ready to merge (and addresses #199), but note that it offers you the Emacs 29 emoji commands as options even if you don't have them. Likewise it binds them to keys. The docstring do mention you need Emacs 29 to use them, but maybe you'd want them to not even appear.

alphapapa commented 10 months ago

Hi Omar,

Thanks, this looks very good. Yes, I would like to have a version check in the option choices to only add ones from Emacs 29 when appropriate; I think we should avoid offering invalid choices to the user whenever possible.

oantolin commented 10 months ago

Sure, I'll add the checks later today.

oantolin commented 10 months ago

Done, I've added the checks. I did it individually for each command because (1) I dislike checking for versions since that seems like an indirect way to say what I mean, (2) maybe someone is running some in between Emacs commit that has some emoji commands but not others.

oantolin commented 10 months ago

I left the mention to Emacs 29 in the docstring unconditionally, think of it as an advertisement. 😛

alphapapa commented 3 months ago

@oantolin Finally merged. Thanks for your work and your patience!

alphapapa commented 3 months ago

@oantolin: Do you think we could make it easier for the user to select one of the other emoji input commands after pressing "C-g"? As it is I have to "describe-keymap ement-room-reaction-map" in another window to know what keys to press.

oantolin commented 3 months ago

Do you think we could make it easier for the user to select one of the other emoji input commands after pressing "C-g"?

Sure, I'd be happy to add a message showing the key bindings.

alphapapa commented 3 months ago

Do you think we could make it easier for the user to select one of the other emoji input commands after pressing "C-g"?

Sure, I'd be happy to add a message showing the key bindings.

Thanks, that would be appreciated.