search

alphapapa / ement.el

A Matrix client for GNU Emacs
GNU General Public License v3.0
476 stars 44 forks source link

Unreachable cond clauses in ement-complete-session, ement--room-display-name #219

Closed progfolio closed 9 months ago

progfolio commented 9 months ago

ement @ 8363bfc

In ement-complete-session:
ement-lib.el:18:778 Warning: Useless clause following default ‘cond’ clause
In ement--room-display-name:
ement-lib.el:47:1506 Warning: Useless clause following default ‘cond’ clause

I believe cl-etypcase forbids the "otherwise" or t clause. Switching to cl-typecase should make the default clauses reachable.

alphapapa commented 9 months ago

Thanks but I don't see those in https://github.com/alphapapa/ement.el/commit/8363bfcdc29468b6e618e38ef880c4cc051da57d. Did you mean a different commit?

progfolio commented 9 months ago

That's the commit I'm running. The byte compiler warning was just added this week, though:

https://github.com/emacs-mirror/emacs/commit/c137b5195b633c5c931c35385fdb3e75b9ee5f09

Helped me catch a couple in my packages, too. (side note: Mattias Engdegard makes top notch contributions)

alphapapa commented 9 months ago

Ah, I see, thanks. I'll look into those after the next release.